qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space


From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space
Date: Tue, 16 Jul 2013 09:06:46 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

On 07/16/2013 01:02 AM, Anthony Liguori wrote:
> Alexey Kardashevskiy <address@hidden> writes:
> 
>> On 07/13/2013 06:03 PM, David Gibson wrote:
>>> On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote:
>>>> sPAPR PHB emulates IO ports on PCI via a special memory region which
>>>> routes all reads/writes further via cpu_in*/cpu_out* which are eventually
>>>> processed by MemoryRegionOps implemented by devices.
>>
>>> Hrm.  That double dispatch was a workaround for bugs in the plain
>>> memory region dispatching which meant we couldn't directly map regions
>>> in memory space to IO areas.
>>>
>>> It would be worth checking if that workaround is still necessary.
>>
>> Hm. Good point, thanks! It seems memory_region_init_io is not necessary any
>> more. Will make a patch for it.
> 
> You should try the latest qemu.git commit.  There shouldn't be a problem
> anymore.


Does this mean sPAPR still needs an additional IO memory region? It looks
redundand and everything (almost) works without it...


-- 
Alexey



reply via email to

[Prev in Thread] Current Thread [Next in Thread]