Re: [Qemu-devel] [PATCH 2/3] migration: notify migration state before starting thread

[Paolo Bonzini]

Il 17/07/2013 11:35, Stefan Hajnoczi ha scritto:
> The migration thread runs outside the QEMU global mutex when possible.
> Therefore we must notify migration state change *before* starting the
> migration thread.
> 
> This allows registered listeners to act before live migration iterations
> begin.  Therefore they can get into a state that allows for live
> migration.  When the migration thread starts everything will be ready.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  migration.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/migration.c b/migration.c
> index 9f5a423..b4daf13 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -625,7 +625,9 @@ void migrate_fd_connect(MigrationState *s)
>      qemu_file_set_rate_limit(s->file,
>                               s->bandwidth_limit / XFER_LIMIT_RATIO);
>  
> +    /* Notify before starting migration thread */
> +    notifier_list_notify(&migration_state_notifiers, s);
> +
>      qemu_thread_create(&s->thread, migration_thread, s,
>                         QEMU_THREAD_JOINABLE);
> -    notifier_list_notify(&migration_state_notifiers, s);
>  }
> 

Acked-by: Paolo Bonzini <address@hidden>