[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions |
Date: |
Wed, 17 Jul 2013 06:24:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/17/2013 04:35 AM, Laszlo Ersek wrote:
>> +# @cpus: #optional VCPUs belong to this node
>> +#
>> +# Since: 1.6
>> +##
>> +{ 'type': 'NumaNodeOptions',
>> + 'data': {
>> + '*nodeid': 'int',
>> + '*cpus': 'str' }}
>> +
>
> Should we document the format for "cpus" here too?
Not only that, but is this even the right representation? The fact that
you are requiring the receiver to further parse this string means you
probably represented it at the wrong level in JSON. That is, a JSON
string "1,2,4" requires post-processing to turn it into 3 processor ids,
while a JSON array [1, 2, 4] does not, so you should probably consider
'*cpus':['int'] as your preferred datatype.
>> +# Since 1.6
>> +##
>> +{ 'type': 'NumaMemOptions',
>> + 'data': {
>> + '*nodeid': 'int',
>> + '*size': 'size' }}
>>
>
> Looks good in general but I'm not sure if hardware tabs are allowed (or
> usual) in this file.
Drop the tabs. Also, this missed soft freeze for 1.6, so you will
probably end up using Since 1.7 by the time it actually gets accepted.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V5 00/12] Add support for binding guest numa nodes to host numa nodes, Wanlong Gao, 2013/07/17
- [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Wanlong Gao, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Laszlo Ersek, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions,
Eric Blake <=
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Laszlo Ersek, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Laszlo Ersek, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Laszlo Ersek, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Laszlo Ersek, 2013/07/17
- Re: [Qemu-devel] [PATCH V5 01/12] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions, Paolo Bonzini, 2013/07/17
[Qemu-devel] [PATCH V5 03/12] NUMA: move numa related code to numa.c, Wanlong Gao, 2013/07/17
[Qemu-devel] [PATCH V5 05/12] NUMA: Add Linux libnuma detection, Wanlong Gao, 2013/07/17