[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] smbios: Improve diagnostics for conflicting
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] smbios: Improve diagnostics for conflicting entries |
Date: |
Wed, 17 Jul 2013 13:09:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/17/2013 11:16 AM, Markus Armbruster wrote:
> We allow either tables or fields for the same type. Makes sense,
> because SeaBIOS uses fields only when no tables are present.
>
> We do this by searching the SMBIOS blob for a previously added table
> or field. Error messages look like this:
>
> qemu-system-x86_64: -smbios type=1,serial=42: SMBIOS type 1 table already
> defined, cannot add field
>
> User needs to know that "table" is defined by -smbios file=..., and
> "field" by -smbios type=...
>
> Instead of searching the blob, record additions of interest, and check
> that. Simpler, and makes better error messages possible:
>
> qemu-system-x86_64: -smbios file=smbios_type_1.bin: Can't mix file= and
> type= for same type
> qemu-system-x86_64: -smbios type=1,serial=42,serial=99: This is the
> conflicting setting
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/i386/smbios.c | 43 +++++++++++++++++--------------------------
> 1 file changed, 17 insertions(+), 26 deletions(-)
Nicer message in fewer lines of code - what's not to like about it?
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/7] smbios cleanup & nicer defaults for type 1, Markus Armbruster, 2013/07/17
- [Qemu-devel] [PATCH 1/7] smbios: Normalize smbios_entry_add()'s error handling to exit(1), Markus Armbruster, 2013/07/17
- [Qemu-devel] [PATCH 3/7] smbios: Improve diagnostics for conflicting entries, Markus Armbruster, 2013/07/17
- Re: [Qemu-devel] [PATCH 3/7] smbios: Improve diagnostics for conflicting entries,
Eric Blake <=
- [Qemu-devel] [PATCH 6/7] vl: Set current_machine early, Markus Armbruster, 2013/07/17
- [Qemu-devel] [PATCH 5/7] smbios: Factor out smbios_maybe_add_str(), Markus Armbruster, 2013/07/17
- [Qemu-devel] [PATCH 7/7] smbios: Set system manufacturer, product & version by default, Markus Armbruster, 2013/07/17
- [Qemu-devel] [PATCH 2/7] smbios: Convert to QemuOpts, Markus Armbruster, 2013/07/17
- [Qemu-devel] [PATCH 4/7] smbios: Make multiple -smbios type= accumulate sanely, Markus Armbruster, 2013/07/17