[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target |
|
Date: |
Thu, 18 Jul 2013 13:29:55 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 17, 2013 at 05:57:37PM +0800, Fam Zheng wrote:
> s->qcow and s->qcow_filename are allocated but not freed on error. Fix the
> possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of
> bdrv_create() and also the one of enable_write_target().
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>
> v2: Fix leak of s->qcow_filename, propagate returen value of
> enable_write_target(). [Laszlo]
>
> ---
> block/vvfat.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan