qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand
Date: Thu, 18 Jul 2013 14:04:31 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/03/2013 08:34 AM, Paolo Bonzini wrote:
> This command dumps the metadata of an entire chain, in either tabular or JSON
> format.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  qemu-img-cmds.hx |   6 ++
>  qemu-img.c       | 186 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 192 insertions(+)
> 

> +    case OFORMAT_JSON:
> +        printf("%s{ 'depth': %d, 'start': %lld, 'length': %lld, "
> +               "'zero': %s, 'data': %s",
> +               (e->start == 0 ? "[" : ",\n"),
> +               e->depth, (long long) e->start, (long long) e->length,
> +               (e->flags & BDRV_BLOCK_ZERO) ? "true" : "false",
> +               (e->flags & BDRV_BLOCK_DATA) ? "true" : "false");
> +        if (e->flags & BDRV_BLOCK_OFFSET_VALID) {
> +            printf(", 'offset': %lld", (long long) e->offset);
> +        }
> +     putchar('}');

Can we please get this format documented in qapi-schema.json, even if we
aren't using qapi to generate it yet?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]