Re: [Qemu-devel] [PATCH v2 07/17] qemu-img: always probe the input image for allocated sectors

[Eric Blake]

On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> qemu-img convert is assuming "that sectors which are unallocated in the input
> image are present in both the output's and input's base images", but it is
> only doing this if the output image is zero initialized.  And checking if
> the output image is zero initialized does not make much sense if the
> output image is copy-on-write.  Always do the test.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  qemu-img.c | 26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature