[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when p
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] linux-user: Handle microMIPS encoding when processing trap exceptions |
Date: |
Fri, 19 Jul 2013 15:52:47 +0100 |
On 19 July 2013 15:47, Kwok Cheung Yeung <address@hidden> wrote:
> Decode trap instructions during the handling of an EXCP_TRAP according to
> the current ISA mode.
>
> Signed-off-by: Kwok Cheung Yeung <address@hidden>
> ---
> linux-user/main.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> v2: Read microMIPS instructions sequentially as 16-bit values to avoid
> endianess issues. Add braces to if statement to conform to formatting
> standards.
This code looks OK but last time round I asked about
EXCP_BREAK -- why doesn't that also need to change?
thanks
-- PMM