[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand |
|
Date: |
Fri, 19 Jul 2013 13:36:50 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> This command dumps the metadata of an entire chain, in either tabular or JSON
> format.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> v1->v2: mention encrypted clusters, use PRId64
>
> qemu-img-cmds.hx | 6 ++
> qemu-img.c | 185
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 191 insertions(+)
Missing a change to qemu-img.texi to list the documentation required there.
It might also help to show a sample of the output in the commit message.
I didn't spot anything else beyond your other reviewers.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 10/17] block: define get_block_status return value, (continued)
- [Qemu-devel] [PATCH v2 11/17] block: return get_block_status data and flags for formats, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 13/17] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 14/17] raw-posix: return get_block_status data and flags, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 15/17] raw-posix: detect XFS unwritten extents, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 16/17] block: add default get_block_status implementation for protocols, Paolo Bonzini, 2013/07/16
- [Qemu-devel] [PATCH v2 17/17] block: look for zero blocks in bs->file, Paolo Bonzini, 2013/07/16