qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] memory: Fix zero-sized memory region print


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] memory: Fix zero-sized memory region print
Date: Fri, 19 Jul 2013 22:09:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

Il 19/07/2013 20:42, Alex Williamson ha scritto:
> if mr->size == 0, then
> 
> int128_get64(int128_sub(mr->size, int128_make64(1))) => assert(!a.hi)
> 
> Also, use int128_one().
> 
> Signed-off-by: Alex Williamson <address@hidden>

Reviewed-by: Paolo Bonzini <address@hidden>

> ---
>  memory.c |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/memory.c b/memory.c
> index c8f9a2b..6e17c21 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1788,7 +1788,9 @@ static void mtree_print_mr(fprintf_function mon_printf, 
> void *f,
>                     "-" TARGET_FMT_plx "\n",
>                     base + mr->addr,
>                     base + mr->addr
> -                   + (hwaddr)int128_get64(int128_sub(mr->size, 
> int128_make64(1))),
> +                   + (int128_nz(mr->size) ?
> +                      (hwaddr)int128_get64(int128_sub(mr->size,
> +                                                      int128_one())) : 0),
>                     mr->priority,
>                     mr->romd_mode ? 'R' : '-',
>                     !mr->readonly && !(mr->rom_device && mr->romd_mode) ? 'W'
> @@ -1803,7 +1805,9 @@ static void mtree_print_mr(fprintf_function mon_printf, 
> void *f,
>                     TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d, %c%c): 
> %s\n",
>                     base + mr->addr,
>                     base + mr->addr
> -                   + (hwaddr)int128_get64(int128_sub(mr->size, 
> int128_make64(1))),
> +                   + (int128_nz(mr->size) ?
> +                      (hwaddr)int128_get64(int128_sub(mr->size,
> +                                                      int128_one())) : 0),
>                     mr->priority,
>                     mr->romd_mode ? 'R' : '-',
>                     !mr->readonly && !(mr->rom_device && mr->romd_mode) ? 'W'
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]