Re: [Qemu-devel] [PATCH V5 1/4] Implement sync modes for drive-backup.

[Ian Main]

On Fri, Jul 19, 2013 at 04:11:13PM -0600, Eric Blake wrote:
> On 07/19/2013 03:49 PM, Ian Main wrote:
> >>> +++ b/qapi-schema.json
> >>> @@ -1807,6 +1807,10 @@
> >>>  # @format: #optional the format of the new destination, default is to
> >>>  #          probe if @mode is 'existing', else the format of the source
> >>>  #
> >>> +# @sync: what parts of the disk image should be copied to the destination
> >>> +#        (all the disk, only the sectors allocated in the topmost image, 
> >>> or
> >>> +#        only new I/O).
> >>> +#
> >>>  # @mode: #optional whether and how QEMU should create a new image, 
> >>> default is
> >>>  #        'absolute-paths'.
> >>>  #
> >>
> >> This hunk is still wrong.  And we still haven't answered the
> >> meta-question on whether @format should be mandatory (which I'd rather
> >> fix that first, then rebase this on top of that).
> > 
> > How is it wrong when it cleanly applies?  You want it separated into
> > another patch?
> 
> It cleanly applied to the wrong place (drive-mirror), no thanks to git's
> automatic fuzzing.  It is _no longer necessary_ - DriveBackup already
> has this information.  I want it dropped completely.

I gotcha sorry I'm slow.

        Ian