Re: [Qemu-devel] [PATCH] gdbstub: fix sThreadInfo handler

[Max Filippov]

On Mon, Jul 22, 2013 at 2:54 PM, Andreas Färber <address@hidden> wrote:
> Am 22.07.2013 07:24, schrieb Max Filippov:
>> After the commit 182735e cpu: Make first_cpu and next_cpu CPUState
>> we can no longer blindly use cpu->next_cpu->env_ptr to get CPUArchState
>> of the next CPU, as the next_cpu is NULL in the last CPU.
>>
>> This fixes segfault caused by gdb command 'info threads'.
>>
>> Signed-off-by: Max Filippov <address@hidden>
>
> This should be obsoleted by the patch on qom-cpu that I pointed you to,
> no? I so far didn't send a pull for that alone since I was hoping to get
> more gdbstub patches in - I added a comment explaining vaddr type as

I've noticed that the other gdbstub fix is in, but debugging is still broken
in the mainline. In fact it had been broken just a few commits after that
fix, in the same pull request.

Holding a fix in order to make a bigger pull request later is not the right
thing IMHO.

> requested by Peter, so a Reviewed-by/Acked-by for the modified Xtensa
> subclasses would help push that forward, and no one bothered to review

Ok, I will review it.

> the ..._read_register() changes yet IIRC, split up on rth's request. I
> could just apply the initial set_pc stuff of course and wait some longer
> with the rest.

-- 
Thanks.
-- Max