[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] exec: Fix bounce buffer allocation in addre
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] exec: Fix bounce buffer allocation in address_space_map() |
|
Date: |
Mon, 22 Jul 2013 15:55:05 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.07.2013 um 15:06 hat Paolo Bonzini geschrieben:
> Il 22/07/2013 14:43, Kevin Wolf ha scritto:
> > - bounce.buffer = qemu_memalign(TARGET_PAGE_SIZE, TARGET_PAGE_SIZE);
> > + /* Avoid unbounded allocations */
> > + l = TARGET_PAGE_SIZE;
>
> This should be l = MIN(l, TARGET_PAGE_SIZE). Otherwise the patch is okay.
Heh, okay. That's what I first had, but then I changed it to revert to
the original behaviour, because I wasn't sure if qemu_memalign requires
the size to be aligned as well.
I'll send a v2.
Kevin