Re: [Qemu-devel] [PATCH qom-cpu] HACKING: Document vaddr type usage

[Andreas Färber]

Am 22.07.2013 19:36, schrieb Peter Maydell:
> On 22 July 2013 18:32, Andreas Färber <address@hidden> wrote:
>> Am 22.07.2013 19:27, schrieb Peter Maydell:
>>> Here's my suggestion for this paragraph (ie to replace
>>> both the "Use target_ulong..." and "Use vaddr" sentences
>>> above):
>>>
>>> ===begin===
>>> For CPU virtual addresses there are several possible types.
>>> vaddr is the best type to use to hold a CPU virtual address
>>> in target-independent code, including most devices. It is
>>
>> Thanks. What reason can you think of for using vaddr in a device?
> 
> I put that in because the existing text says "devices should
> not need to use target_ulong" and they obviously shouldn't
> use abi_ulong, leaving only vaddr if they want to play with
> target virtual addresses. I agree that most devices shouldn't
> care about virtual addresses at all, though, so it's probably
> less confusing to just drop the ", including most devices" bit.
> 
> PS, I dunno if this amount of text needs a signoff, but you have my
> Signed-off-by: Peter Maydell <address@hidden>
> in case it matters.

Thanks, I've attributed it to you and applied without the devices bit:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg