qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling cod


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code.
Date: Tue, 23 Jul 2013 16:31:13 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jul 23, 2013 at 02:21:03PM +0200, Benoît Canet wrote:
> The throttling code was segfaulting since commit
> 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next 
> caller
> does not run in a coroutine.
> qemu_co_queue_do_restart assume that the caller is a coroutinne.
> As sugested by Stefan fix this by entering the coroutine directly.

Please mark qemu_co_queue_next() and qemu_co_queue_restart_all()
coroutine_fn.  They may only be called from coroutine context.

Also please add assert(qemu_in_coroutine()) to these functions so an
assertion fires when they are used incorrectly.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]