Re: [Qemu-devel] [PATCH v7 01/10] configure: Support configuring C++ compiler

[Tomoki Sekiyama]

Hi Michael,
Thanks for your review.

On 7/22/13 16:53 , "Michael Roth" <address@hidden> wrote:

>Quoting Tomoki Sekiyama (2013-07-15 11:20:29)
>> Add configuration for C++ compiler in configure and Makefiles.
>> The C++ compiler is choosed as following:
>>  - ${CXX}, if it is specified.
>>  - ${cross_prefix}g++, if ${cross_prefix} is specified.
>>  - Otherwise, c++ is used.
>> 
>> Currently, usage of C++ language is only for access to Windows VSS
>> using COM+ services in qemu-guest-agent for Windows.
>> 
>> Signed-off-by: Tomoki Sekiyama <address@hidden>
>> Reviewed-by: Laszlo Ersek <address@hidden>
>> ---
>>  configure |   13 +++++++++++++
>>  rules.mak |    9 ++++++++-
>>  2 files changed, 21 insertions(+), 1 deletion(-)
>> 
>> diff --git a/configure b/configure
>> index cb0f870..6923b65 100755
>> --- a/configure
>> +++ b/configure
>> @@ -251,6 +251,8 @@ for opt do
>>    ;;
>>    --cc=*) CC="$optarg"
>>    ;;
>> +  --cxx=*) CXX="$optarg"
>> +  ;;
>>    --source-path=*) source_path="$optarg"
>>    ;;
>>    --cpu=*) cpu="$optarg"
>> @@ -281,6 +283,12 @@ else
>>    cc="${CC-${cross_prefix}gcc}"
>>  fi
>> 
>> +if test -z "${CXX}${cross_prefix}"; then
>> +  cxx="c++"
>> +else
>> +  cxx="${CXX-${cross_prefix}g++}"
>> +fi
>> +
>>  ar="${AR-${cross_prefix}ar}"
>>  as="${AS-${cross_prefix}as}"
>>  cpp="${CPP-$cc -E}"
>> @@ -621,6 +629,8 @@ for opt do
>>    ;;
>>    --host-cc=*) host_cc="$optarg"
>>    ;;
>> +  --cxx=*) cxx="$optarg"
>> +  ;;
>
>Since we've already determined cxx in the first pass (overriding other
>defaults --cxx argument if it's present), I think re-assigning here
>is unecessary.
>
>Otherwise looks good.

OK, I will remove the assignment.

Thanks,
Tomoki Sekiyama