Re: [Qemu-devel] [PATCH V6 2/3] Add tests for sync modes 'TOP' and 'NONE'

[Kevin Wolf]

Am 23.07.2013 um 00:09 hat Ian Main geschrieben:
> This patch adds tests for sync modes top and none.  Also added are tests
> for invalid and missing formats.
> 
> Signed-off-by: Ian Main <address@hidden>
> ---
>  tests/qemu-iotests/055        | 108 
> +++++++++++++++++++++++++++++++++++++-----
>  tests/qemu-iotests/055.out    |   4 +-
>  tests/qemu-iotests/group      |   2 +-
>  tests/qemu-iotests/iotests.py |   5 ++
>  4 files changed, 103 insertions(+), 16 deletions(-)

> @@ -127,7 +202,8 @@ class TestSetSpeed(iotests.QMPTestCase):
>          self.assert_qmp(result, 'return[0]/device', 'drive0')
>          self.assert_qmp(result, 'return[0]/speed', 0)
>  
> -        result = self.vm.qmp('block-job-set-speed', device='drive0', speed=8 
> * 1024 * 1024)
> +        result = self.vm.qmp('block-job-set-speed', device='drive0',
> +                             speed=8 * 1024 * 1024)

Forgot adding sync?

>          self.assert_qmp(result, 'return', {})
>  
>          # Ensure the speed we set was accepted

> @@ -285,4 +367,4 @@ class TestSingleTransaction(iotests.QMPTestCase):
>          self.assert_no_active_block_jobs()
>  
>  if __name__ == '__main__':
> -    iotests.main(supported_fmts=['raw', 'qcow2'])
> +    iotests.main(supported_fmts=['qcow2', 'qed'])

Not good. Can we split the test in a part that can be run by raw, and a
separate part that uses backing files?

Kevin