[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] [PATCH] linux-user: implement m68k atomic syscall
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC] [PATCH] linux-user: implement m68k atomic syscalls |
|
Date: |
Wed, 24 Jul 2013 08:43:53 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/23/2013 09:10 PM, address@hidden wrote:
> +#ifdef TARGET_NR_atomic_cmpxchg_32
> + case TARGET_NR_atomic_cmpxchg_32:
> + {
> + /* should use start_exclusive from main.c */
> + abi_ulong mem_value;
> + if (get_user_u32(mem_value, arg6))
> + ret = -TARGET_EFAULT;
> + if (mem_value == arg2)
> + put_user_u32(arg1, arg6);
> + ret = mem_value;
> + break;
> + }
The ret = -TARGET_FAULT doesn't do anything useful
without an associated break.
The kernel queues the expected SIGSEGV for this sort
of failure. Would that happen here?
r~