Re: [Qemu-devel] [PATCH v2 07/11] block: hold hard reference for backup/mirror target

[Stefan Hajnoczi]

On Thu, Jul 25, 2013 at 02:08:42PM +0800, Fam Zheng wrote:
> On Tue, 07/23 11:52, Stefan Hajnoczi wrote:
> > On Wed, Jul 17, 2013 at 05:42:12PM +0800, Fam Zheng wrote:
> > > Signed-off-by: Fam Zheng <address@hidden>
> > > ---
> > >  block/backup.c | 3 ++-
> > >  block/mirror.c | 4 ++--
> > >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > Should we update the blockjob.c in_use code instead of adding
> > refcounting to specific block jobs?  This ought to be handled
> > generically for all block jobs.
> 
> Target is not common in block jobs (e.g. doesn't apply to block-commit),
> so it seems only specific block job knows about this.

Of course you are right.

Stefan