Re: [Qemu-devel] [PATCH] [RFC] aio/timers: Drop alarm timers; introduce QEMUClock to AioContext; run timers in aio_poll

[Stefan Hajnoczi]

On Fri, Jul 19, 2013 at 06:26:23PM +0100, Alex Bligh wrote:
> [ This is a patch for RFC purposes only. It is compile tested on Linux x86_64 
> only
> and passes make check (or rather did before make check started dying in the
> boot order test - different bug). I'd like to know whether I'm going in
> the right direction ]
> 
> We no longer need alarm timers to trigger QEMUTimer as we'll be polling
> them in aio_poll.
> 
> Remove static declaration from qemu_new_clock and introduce qemu_free_clock.
> 
> Maintain a list of QEMUClocks.
> 
> Introduce qemu_clock_deadline_ns and qemu_clock_deadine_all_ns which 
> calculate how
> long aio_poll etc. should wait, plus (for the time being) a conversion to 
> milliseconds.
> 
> Make qemu_run_timers return a bool to indicate progress.
> 
> Add QEMUClock to AioContext.
> 
> Run timers attached to clock in aio_poll
> 
> Signed-off-by: Alex Bligh <address@hidden>
> ---
>  aio-posix.c          |   16 +-
>  aio-win32.c          |   20 +-
>  async.c              |    2 +
>  include/block/aio.h  |    5 +
>  include/qemu/timer.h |   15 +-
>  main-loop.c          |    9 +-
>  qemu-timer.c         |  599 
> ++++++++------------------------------------------
>  vl.c                 |    5 +-
>  8 files changed, 150 insertions(+), 521 deletions(-)

I think you've already split this into a series.  Will review that, just
catching up on your emails :).

Stefan