[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] hw/virtio/virtio-mmio: Make QueueNumMax rea
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues |
|
Date: |
Thu, 25 Jul 2013 23:37:57 +0100 |
On 25 July 2013 23:34, Michael S. Tsirkin <address@hidden> wrote:
> On Thu, Jul 25, 2013 at 02:37:43PM +0100, Peter Maydell wrote:
>> case VIRTIO_MMIO_QUEUENUMMAX:
>> + if (virtio_queue_get_num(vdev, vdev->queue_sel) == 0) {
>> + return 0;
>> + }
>
> All other callers do:
> if (!virtio_queue_get_num(vdev, vdev->queue_sel)) {
>
> So please make this one consistent and use the shorter form.
OK.
-- PMM
[Qemu-devel] [PATCH 2/2] hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues, Peter Maydell, 2013/07/25