[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] tests: QAPI schema parser tests |
Date: |
Fri, 26 Jul 2013 06:48:33 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/26/2013 06:39 AM, Markus Armbruster wrote:
> The parser handles erroneous input badly. To be improved shortly.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
Lots of proof on how bad it is! I'd also like to see a couple tests on
trailing commas:
{ 'enum': 'Foo', [ 'bar' ], }
{ 'enum': 'Gur', [ 'ble', ] }
since we have had patches in the past to clean them up (shame on JSON
for copying C89 instead of C99 with regards to trailing commas).
Either way,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH 3/9] qapi.py: Restructure lexer and parser, Markus Armbruster, 2013/07/26
[Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test, Markus Armbruster, 2013/07/26
Re: [Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it, Anthony Liguori, 2013/07/26