[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types |
Date: |
Fri, 26 Jul 2013 07:06:34 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/23/2013 07:03 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> docs/qapi-code-gen.txt | 58
> +++++++++++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 53 insertions(+), 5 deletions(-)
> +=== Complex types ===
>
> A complex type is a dictionary containing a single key who's value is a
pre-existing, but as long as you are touching this, fix the grammar:
s/who's/whose/
> dictionary. This corresponds to a struct in C or an Object in JSON. An
> @@ -47,13 +53,57 @@ The use of '*' as a prefix to the name means the member
> is optional. Optional
> members should always be added to the end of the dictionary to preserve
> backwards compatibility.
>
> +=== Enumeration types ===
> +
> An enumeration type is a dictionary containing a single key who's value is a
s/who's/whose/
With those fixes,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 01/18] qapi-types.py: Split off generate_struct_fields(), (continued)
- [Qemu-devel] [PATCH 03/18] qapi-visit.py: Split off generate_visit_struct_fields(), Kevin Wolf, 2013/07/23
- [Qemu-devel] [PATCH 04/18] qapi-visit.py: Implement 'base' for unions, Kevin Wolf, 2013/07/23
- [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions, Kevin Wolf, 2013/07/23
- [Qemu-devel] [PATCH 06/18] qapi: Add visitor for implicit structs, Kevin Wolf, 2013/07/23
- [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types, Kevin Wolf, 2013/07/23
- Re: [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types,
Eric Blake <=
- [Qemu-devel] [PATCH 07/18] qapi: Flat unions with arbitrary discriminator, Kevin Wolf, 2013/07/23
- [Qemu-devel] [PATCH v2 07/17] qapi: Flat unions with arbitrary discriminator, Kevin Wolf, 2013/07/26
- [Qemu-devel] [PATCH 09/18] qapi.py: Maintain a list of union types, Kevin Wolf, 2013/07/23
- [Qemu-devel] [PATCH 08/18] qapi: Add consume argument to qmp_input_get_object(), Kevin Wolf, 2013/07/23