qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes


From: Markus Armbruster
Subject: [Qemu-devel] [PATCH v2 0/3] qemu-char: ringbuf fixes
Date: Fri, 26 Jul 2013 16:44:31 +0200

Fix code to match documentation.  The patches take pains to preserve
command-line, HMP and QMP bug-compatibility.  I'm not sure that's
actually needed, because:

* All: the documented way to use the driver never worked in any
  released version, and the way that worked was undocumented.

* QMP: I doubt anyone used chardev-add / chardev-remove in anger,
  because serious use surely would've run into the bug fixed in commit
  commit 2ea3e2c "qemu-char: Fix ID reuse after chardev-remove for
  qapi-based init".

I include the compatibility gunk anyway, so we can have a more
informed discussion.

You might want to apply this after my "Our QAPI parser is a hack,
replace it" series, so the indented comment in PATCH 3/3 works by
design rather than accident.

v2: Trivially rebased

Markus Armbruster (3):
  Revert "chardev: Make the name of memory device consistent"
  qemu-char: Register ring buffer driver with correct name "ringbuf"
  qapi: Rename ChardevBackend member "memory" to "ringbuf"

 qapi-schema.json | 12 +++++++-----
 qemu-char.c      | 26 +++++++++++++++-----------
 qemu-options.hx  |  6 +++---
 3 files changed, 25 insertions(+), 19 deletions(-)

-- 
1.7.11.7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]