Re: [Qemu-devel] [PATCH 13/18] blockdev: Rename I/O throttling options for QMP

[Eric Blake]

On 07/26/2013 10:26 AM, Kevin Wolf wrote:

>> This patch will probably conflict with Benoît's work on leaky bucket
>> throttling; can the two of you decide which one should go in first?  Are
>> we trying to target both this series and leaky bucket throttling for 1.6?
> 
> If you complete the review before I leave today, I might still send a
> pull request, but as I'm going to disable blockdev-add and the new
> options once again for 1.6, it doesn't really matter that much.

In other words, just as it was in 1.5, the new parser is cool enough to
implement the framework now to ease backport efforts, but untested
enough that we'd rather defer use of that framework until after we are
back out of freeze.

> 
> Benoît's series is for 1.7 as well, if I understood Stefan correctly. He

Even though the latest subject line requests for-1.6?
https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg04005.html

> said he was going to merge a bug fix part of it for 1.6 and leave the
> rest for 1.7. (I haven't been following the throttling series myself,
> that's why I can't comment in much more detail.)

I guess I also need to comment on that series - we're late enough that
bug fixes are okay, but new options are risky; and the tail end of that
series adds new options to throttling as part of switching to a new
algorithm.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature