[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.
|
From: |
Ian Main |
|
Subject: |
Re: [Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup. |
|
Date: |
Fri, 26 Jul 2013 10:15:09 -0700 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jul 26, 2013 at 08:58:16AM +0200, Paolo Bonzini wrote:
> Il 26/07/2013 03:09, Ian Main ha scritto:
> > + /* See if we have a backing HD we can use to create our new image
> > + * on top of. */
> > + source = bs->backing_hd;
> > + if (!source && sync == MIRROR_SYNC_MODE_TOP) {
> > + sync = MIRROR_SYNC_MODE_FULL;
> > + }
> > +
>
> I understand why you left out the "magic" backing file manipulation, but
> source should still be "bs" for MIRROR_SYNC_MODE_NONE.
OK. Eventually I'll get it right :)
Ian