|
From: | Alex Bligh |
Subject: | Re: [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code. |
Date: | Fri, 26 Jul 2013 20:42:11 +0100 |
--On 26 July 2013 13:16:04 -0600 Eric Blake <address@hidden> wrote:
- while (qemu_co_queue_next(&bs->throttled_reqs)); + while (qemu_co_enter_next(&bs->throttled_reqs)) { + }On first read, I missed the s/queue/enter/ change and thought all you were doing was the s/;/{}/ change. Is the style change necessary to keep checkpatch.pl happy? If not, then keeping the old style would draw better attention to the bug fix.
checkpatch.pl doesn't like: while (func()); It appears happy with: do {} while (func()); which is marginally less ugly than: while (func()) { }; in my opinion, particularly when used multiple times in succession. I think this is probably a bug in checkpatch.pl. -- Alex Bligh
[Prev in Thread] | Current Thread | [Next in Thread] |