[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test |
Date: |
Sat, 27 Jul 2013 17:34:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 07/26/2013 06:39 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> qapi-schema-test.json | 53 ---------------------------------
>> tests/Makefile | 8 ++---
>> tests/qapi-schema/qapi-schema-test.exit | 1 +
>> tests/qapi-schema/qapi-schema-test.json | 53
>> +++++++++++++++++++++++++++++++++
>
> You don't have git rename detection turned on? You get a more compact
> listing of file renames if you do:
> git config diff.renames true
Now I do.
> I just modified http://wiki.qemu.org/Contribute/SubmitAPatch to mention
> this tip.
Good move.
>> tests/qapi-schema/qapi-schema-test.out | 19 ++++++++++++
>> 5 files changed, 77 insertions(+), 57 deletions(-)
>> delete mode 100644 qapi-schema-test.json
>> create mode 100644 tests/qapi-schema/qapi-schema-test.err
>> create mode 100644 tests/qapi-schema/qapi-schema-test.exit
>> create mode 100644 tests/qapi-schema/qapi-schema-test.json
>> create mode 100644 tests/qapi-schema/qapi-schema-test.out
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH 6/9] qapi.py: Fix schema parser to check syntax systematically, (continued)
[Qemu-devel] [PATCH 3/9] qapi.py: Restructure lexer and parser, Markus Armbruster, 2013/07/26
[Qemu-devel] [PATCH 2/9] tests: Use qapi-schema-test.json as schema parser test, Markus Armbruster, 2013/07/26
Re: [Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it, Anthony Liguori, 2013/07/26