[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine |
Date: |
Sun, 28 Jul 2013 12:08:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 28.07.2013 09:29, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> hw/i386/pc_q35.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 0b1d2e3..5140caf 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -130,7 +130,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
>
> /* create pci host bus */
> q35_host = Q35_HOST_DEVICE(qdev_create(NULL, TYPE_Q35_HOST_DEVICE));
> -
> + object_property_add_child(qdev_get_machine(), "q35", OBJECT(q35_host),
> NULL);
> q35_host->mch.ram_memory = ram_memory;
> q35_host->mch.pci_address_space = pci_memory;
> q35_host->mch.system_memory = get_system_memory();
Reviewed-by: Andreas Färber <address@hidden>
Thanks a lot, I was about to send the equivalent patch!
This is a Last Minute guest-visible change, but it matches what we have
for i440fx, so I consider this fine.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-devel] [PATCH 2/6] pc: add I440FX QOM cast macro, (continued)
[Qemu-devel] [PATCH 1/6] pc: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/ioapic.h, Igor Mammedov, 2013/07/28
[Qemu-devel] [PATCH 3/6] utils: add range_size() wrapper, Igor Mammedov, 2013/07/28
[Qemu-devel] [PATCH 4/6] pc: replace i440fx_common_init() with i440fx_init() as it isn't used by anywhere else, Igor Mammedov, 2013/07/28
[Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine, Igor Mammedov, 2013/07/28
- Re: [Qemu-devel] [PATCH 5/6] pc: add Q35 to QOM composition tree under /machine,
Andreas Färber <=
[Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Igor Mammedov, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Michael S. Tsirkin, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Igor Mammedov, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Michael S. Tsirkin, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Andreas Färber, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Igor Mammedov, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Michael S. Tsirkin, 2013/07/28
- Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Michael Roth, 2013/07/30
Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Igor Mammedov, 2013/07/28
Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default, Michael S. Tsirkin, 2013/07/28