Re: [Qemu-devel] [PATCH 3/3] memory: Return -1 again on reads from unsigned regions

[Andreas Färber]

Am 16.07.2013 17:31, schrieb Paolo Bonzini:
> From: Jan Kiszka <address@hidden>
> 
> This restore the behavior prior to b018ddf633 which accidentally changed
> the return code to 0. Specifically guests probing for register existence
> were affected by this.
> 
> Signed-off-by: Jan Kiszka <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Unfortunately this negatively affects PReP: OpenHack'Ware booting Debian
Etch prints:

ERROR: WIN_READ_NATIVE_MAX : status 50 != 0x40

It does continue if one is patient enough.
No problems before this commit.

Any ideas, except that OHW may be doing Bad Things?

Andreas

> ---
>  memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/memory.c b/memory.c
> index 9938b6b..34a088e 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -840,7 +840,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr 
> addr,
>      if (current_cpu != NULL) {
>          cpu_unassigned_access(current_cpu, addr, false, false, 0, size);
>      }
> -    return 0;
> +    return -1ULL;
>  }
>  
>  static void unassigned_mem_write(void *opaque, hwaddr addr,
>