[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly |
Date: |
Tue, 30 Jul 2013 15:48:02 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jul 26, 2013 at 03:10:45PM +0900, MORITA Kazutaka wrote:
> If qemu_co_recv/send doesn't return the specified length, it means
> that an error happened.
>
> Tested-and-reviewed-by: Liu Yuan <address@hidden>
> Signed-off-by: MORITA Kazutaka <address@hidden>
> ---
> block/sheepdog.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 6a41ad9..c6e9b89 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -489,13 +489,13 @@ static coroutine_fn int send_co_req(int sockfd,
> SheepdogReq *hdr, void *data,
> int ret;
>
> ret = qemu_co_send(sockfd, hdr, sizeof(*hdr));
> - if (ret < sizeof(*hdr)) {
> + if (ret != sizeof(*hdr)) {
> error_report("failed to send a req, %s", strerror(errno));
Does this rely on qemu_co_send_recv() getting ret=-1 errno=EPIPE from
iov_send_recv()? I want to check that I understand what happens when
the socket is closed by the other side.
Stefan
- [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 02/10] iov: handle EOF in iov_send_recv, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 10/10] sheepdog: check simultaneous create in resend_aioreq, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 01/10] ignore SIGPIPE in qemu-img and qemu-io, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly, MORITA Kazutaka, 2013/07/26
- Re: [Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v4 05/10] sheepdog: reload inode outside of resend_aioreq, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 09/10] sheepdog: cancel aio requests if possible, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 08/10] sheepdog: make add_aio_request and send_aioreq void functions, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 07/10] sheepdog: try to reconnect to sheepdog after network error, MORITA Kazutaka, 2013/07/26
- [Qemu-devel] [PATCH v4 04/10] sheepdog: handle vdi objects in resend_aio_req, MORITA Kazutaka, 2013/07/26
- Re: [Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure, Stefan Hajnoczi, 2013/07/30