[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/8] s390x/kvm: Remove redundant return code
From: |
Christian Borntraeger |
Subject: |
[Qemu-devel] [PATCH 7/8] s390x/kvm: Remove redundant return code |
Date: |
Tue, 30 Jul 2013 16:23:14 +0200 |
From: Thomas Huth <address@hidden>
Removed the redundant return code statement from handle_instruction() - it
always returned 0 and never reports any errors to its caller, since errors
from the sub-functions are already reported via program exceptions instead.
Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Christian Borntraeger <address@hidden>
---
target-s390x/kvm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
index eff8d28..26d18e3 100644
--- a/target-s390x/kvm.c
+++ b/target-s390x/kvm.c
@@ -693,7 +693,7 @@ out:
return 0;
}
-static int handle_instruction(S390CPU *cpu, struct kvm_run *run)
+static void handle_instruction(S390CPU *cpu, struct kvm_run *run)
{
unsigned int ipa0 = (run->s390_sieic.ipa & 0xff00);
uint8_t ipa1 = run->s390_sieic.ipa & 0x00ff;
@@ -719,7 +719,6 @@ static int handle_instruction(S390CPU *cpu, struct kvm_run
*run)
if (r < 0) {
enter_pgmcheck(cpu, 0x0001);
}
- return 0;
}
static bool is_special_wait_psw(CPUState *cs)
@@ -739,7 +738,7 @@ static int handle_intercept(S390CPU *cpu)
(long)cs->kvm_run->psw_addr);
switch (icpt_code) {
case ICPT_INSTRUCTION:
- r = handle_instruction(cpu, run);
+ handle_instruction(cpu, run);
break;
case ICPT_WAITPSW:
/* disabled wait, since enabled wait is handled in kernel */
--
1.8.3.1
- [Qemu-devel] [PULLv2 0/8] s390 patch queue, Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 1/8] s390/sclpconsole: handle char layer busy conditions, Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 6/8] s390x/kvm: Reworked/fixed handling of cc3 in kvm_handle_css_inst(), Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 3/8] s390x/ioinst: Throw addressing exception when memory_map failed, Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 7/8] s390x/kvm: Remove redundant return code,
Christian Borntraeger <=
- [Qemu-devel] [PATCH 8/8] s390: Implement dump-guest-memory support for target s390x, Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 4/8] s390x/ioinst: Fixed alignment check in SCHM instruction, Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 5/8] s390x/ioinst: Fixed priority of operand exceptions, Christian Borntraeger, 2013/07/30
- [Qemu-devel] [PATCH 2/8] s390x/ioinst: Add missing alignment checks for IO instructions, Christian Borntraeger, 2013/07/30