[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command |
Date: |
Tue, 30 Jul 2013 13:44:23 -0400 |
On Fri, 26 Jul 2013 20:14:06 +0200
Kevin Wolf <address@hidden> wrote:
> Am 26.07.2013 um 19:45 hat Eric Blake geschrieben:
> > Overall, I like where this is headed, but I'm not quite sure it is ready
> > for commit as-is; looking forward to v2. Given my positive review on
> > the rest of the series, I think you could get away with a pull request
> > on the front half of the series and only respinning this patch, instead
> > of needing (re-)review of the entire series.
>
> Yup, that's exactly what I'm going to do now. I had considered merging
> the whole series, but I think you're right that committing it now might
> be a bit early. My main concern were potential conflicts in the front
> "half" (17/18) of the series when I'd wait too long with committing.
Just to double check I got it as I'm still catching up with email
after vacation: you did exactly what was suggested by Eric, you
merged 1-17 and will post the blockdev-add command for 1.7?
- [Qemu-devel] [PATCH 14/18] qcow2: Use dashes instead of underscores in options, (continued)