[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longe
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command |
Date: |
Tue, 30 Jul 2013 15:21:56 -0500 |
User-agent: |
alot/0.3.4 |
Quoting Tomoki Sekiyama (2013-07-23 17:46:06)
> guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
> disk I/O is running. To avoid unexpected timeout, this changes the timeout
> to 60 seconds (timeout of pre-commit phase of VSS).
>
> Signed-off-by: Tomoki Sekiyama <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
> ---
> QMP/qemu-ga-client | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/QMP/qemu-ga-client b/QMP/qemu-ga-client
> index 46676c3..b5f7e7c 100755
> --- a/QMP/qemu-ga-client
> +++ b/QMP/qemu-ga-client
> @@ -267,7 +267,9 @@ def main(address, cmd, args):
> print('Hint: qemu is not running?')
> sys.exit(1)
>
> - if cmd != 'ping':
> + if cmd == 'fsfreeze' and args[0] == 'freeze':
> + client.sync(60)
> + elif cmd != 'ping':
> client.sync()
>
> globals()['_cmd_' + cmd](client, args)
- [Qemu-devel] [PATCH v8 03/10] checkpatch.pl: Check .cpp files, (continued)
- [Qemu-devel] [PATCH v8 03/10] checkpatch.pl: Check .cpp files, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 04/10] Add a script to extract VSS SDK headers on POSIX system, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 06/10] error: Add error_set_win32 and error_setg_win32, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install', Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler, Tomoki Sekiyama, 2013/07/23
- [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command, Tomoki Sekiyama, 2013/07/23
- Re: [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command,
Michael Roth <=
- [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Tomoki Sekiyama, 2013/07/23
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Michael Roth, 2013/07/25
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Michael Roth, 2013/07/26
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Tomoki Sekiyama, 2013/07/29
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Michael Roth, 2013/07/30
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Tomoki Sekiyama, 2013/07/30
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Michael Roth, 2013/07/30
- Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL, Tomoki Sekiyama, 2013/07/30