[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type p
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided |
Date: |
Wed, 31 Jul 2013 10:03:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 31.07.2013 08:54, schrieb Michal Novotny:
> there are
> still some code parts that are not using error_report() as well, e.g.
>
> fprintf(stderr, "Error: standard VGA not available\n");
>
> in the select_vgahw() function (line 2168) or:
>
> fprintf(stderr, "Failed to start VNC server on `%s': %s\n",
> vnc_display, error_get_pretty(local_err));
>
> on line 4385 or:
>
> fprintf(stderr, "-incoming %s: %s\n", incoming,
> error_get_pretty(local_err));
>
> on line 4428 (I've been looking just to vl.c file so far).
>
> Shouldn't all this be using error_report() as well? If so, a follow-up
> patch would be nice.
See http://patchwork.ozlabs.org/patch/260801/ for a start. :)
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg