Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

[Andreas Färber]

Am 31.07.2013 08:54, schrieb Michal Novotny:
> there are
> still some code parts that are not using error_report() as well, e.g.
> 
> fprintf(stderr, "Error: standard VGA not available\n");
> 
> in the select_vgahw() function (line 2168) or:
> 
>             fprintf(stderr, "Failed to start VNC server on `%s': %s\n",
>                     vnc_display, error_get_pretty(local_err));
> 
> on line 4385 or:
> 
> fprintf(stderr, "-incoming %s: %s\n", incoming,
> error_get_pretty(local_err));
> 
> on line 4428 (I've been looking just to vl.c file so far).
> 
> Shouldn't all this be using error_report() as well? If so, a follow-up
> patch would be nice.

See http://patchwork.ozlabs.org/patch/260801/ for a start. :)

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg