Re: [Qemu-devel] [PATCH v5 0/2] e1000: add interrupt mitigation support

[Andreas Färber]

Am 31.07.2013 10:13, schrieb Vincenzo Maffione:
> Implement interrupt mitigation for the e1000 device with the
> corresponding "mitigation" device property.
> 
> Add a compat_props entry to pc-1.6 machines in order to set the
> "mitigation" property for these machines.
> 
> Vincenzo Maffione (2):
>   e1000: add interrupt mitigation support
>   i386/pc: introducing compat_props for pc-1.6

This is not what Stefan asked you to do: PC_COMPAT_1_6 should be
prepared first, then comes your patch adding the property to it.
Otherwise a) git-bisect is not consistent wrt mitigation in pc-*-1.5 and
b) the patch cannot be as easily reused for other devices needing
compat_props.

Andreas

> 
>  hw/i386/pc_piix.c    |   4 ++
>  hw/i386/pc_q35.c     |   4 ++
>  hw/net/e1000.c       | 131 
> +++++++++++++++++++++++++++++++++++++++++++++++++--
>  include/hw/i386/pc.h |   7 +++
>  4 files changed, 143 insertions(+), 3 deletions(-)
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg