Re: [Qemu-devel] [PATCH] qemu-ga: build it even if !system

[Andreas Färber]

Am 31.07.2013 13:05, schrieb Peter Maydell:
> On 31 July 2013 11:27, Michael Tokarev <address@hidden> wrote:
>> 31.07.2013 14:24, Michael Tokarev wrote:
>>> Move qemu-ga build check out of if softmmu.. into if tools section.
>>> We want to build qemu-ga for _guest_ even if system build isn't
>>> done.  It is controlled separately using --enable-guest-agent.
>>
>> Actually the more I think about it... Maybe it shouldn't depend
>> on --enable-tools either, but should be an independent option.
>> Because it isn't really a tool.
> 
> This seems to me to be unnecessarily breaking things down
> into very finely divided categories. I think putting it
> in --enable-tools is fine.

I disagree. Think about building a Windows guest agent: You don't need
qemu-img (tools) on a Windows guest, and mjt is right that it shouldn't
be coupled to building any qemu-system-*.

However it looks as if the linux/bsd/solaris checks got lost in the patch?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg