qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from u


From: Jan Kiszka
Subject: [Qemu-devel] [PATCH 2/2] Revert "memory: Return -1 again on reads from unsigned regions"
Date: Sat, 03 Aug 2013 10:31:14 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

From: Jan Kiszka <address@hidden>

This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71.

The commit was wrong: We only return -1 on invalid accesses, not on
valid but unbacked ones. This broke various corner cases.

Signed-off-by: Jan Kiszka <address@hidden>
---
 memory.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/memory.c b/memory.c
index ac6f3c6..7a0251d 100644
--- a/memory.c
+++ b/memory.c
@@ -873,7 +873,7 @@ static uint64_t unassigned_mem_read(void *opaque, hwaddr 
addr,
     if (current_cpu != NULL) {
         cpu_unassigned_access(current_cpu, addr, false, false, 0, size);
     }
-    return -1ULL;
+    return 0;
 }
 
 static void unassigned_mem_write(void *opaque, hwaddr addr,
-- 
1.7.3.4



reply via email to

[Prev in Thread] Current Thread [Next in Thread]