qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] CHECKPATH issue


From: Alex Bligh
Subject: [Qemu-devel] CHECKPATH issue
Date: Sun, 04 Aug 2013 19:09:20 +0100

checkpatch seems to do different things if called with a wildcard than
just the patch file.

This is from patch 7 in a series I'm just about to post. It's
now claiming it wants no space after the *, but whilst developing
it it complained the spaces around the * did not balance (as if
it were multiplication).

--
Alex Bligh


$ scripts/checkpatch.pl aio-timer-patches-5/* 2>&1 | fgrep -B6 0007-aio-timers
ERROR: "foo * bar" should be "foo *bar"
#27: FILE: include/qemu/timer.h:22:
+typedef QEMUTimerList * QEMUTimerListGroup[QEMU_CLOCK_MAX];

total: 1 errors, 0 warnings, 80 lines checked

aio-timer-patches-5/0007-aio-timers-Add-QEMUTimerListGroup-and-helper-functio.patch has style problems, please review. If any of these errors

$ scripts/checkpatch.pl aio-timer-patches-5/0007-aio-timers-Add-QEMUTimerListGroup-and-helper-functio.patch
total: 0 errors, 0 warnings, 80 lines checked

aio-timer-patches-5/0007-aio-timers-Add-QEMUTimerListGroup-and-helper-functio.patch has no obvious style problems and is ready for submission.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]