[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.6] qemu-img: Error out for excess argument
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.6] qemu-img: Error out for excess arguments |
|
Date: |
Tue, 6 Aug 2013 10:09:12 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 05, 2013 at 10:57:40AM +0200, Kevin Wolf wrote:
> Don't silently ignore excess arguments at the end of the command line,
> but error out instead. This can catch typos like 'resize test.img + 1G',
> which doesn't increase the image size by 1G as intended, but truncates
> the image to 1G. Even for less dangerous commands, the old behaviour is
> confusing.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qemu-img.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>