Re: [Qemu-devel] [RFC] [PATCHv6 10/16] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

[Alex Bligh]

Stefan,

--On 6 August 2013 14:40:00 +0200 Stefan Hajnoczi <address@hidden> 
wrote:

> On Tue, Aug 06, 2013 at 10:16:26AM +0100, Alex Bligh wrote:
> > @@ -180,7 +189,7 @@ aio_ctx_check(GSource *source)
> >              return true;
> >         }
> >      }
> > -    return aio_pending(ctx);
> > +    return aio_pending(ctx) || (timerlistgroup_deadline_ns(ctx->tlg) >=
> > 0);
>
> Now we always dispatch if there is a timer?  Should this comparison be
> timerlistgroup_deadline_ns(ctx->tlg) == 0 instead to only dispatch
> expired timers?

I think you are right.

--
Alex Bligh