Re: [Qemu-devel] [PATCH for-1.6] qemu-timer: fix get_clock() gettimeofday() fallback #ifdef

[Brad Smith]

On 06/08/13 7:48 AM, Stefan Hajnoczi wrote:
> If CLOCK_MONOTONIC is not defined by system headers we use
> gettimeofday(2).  Apparently this is not used very often since no one
> noticed the #ifdef was actually broken and left the function definition
> unterminated.

Can you show what this supposedly fixes? This code built just fine on
OpenBSD before d05ef160453e98546a4197496dc8a3cb2defac53.

> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>   include/qemu/timer.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index 9dd206c..e3299b8 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -125,8 +125,8 @@ static inline int64_t get_clock(void)
>              changes, so it should be avoided. */
>           return get_clock_realtime();
>       }
> -}
>   #endif
> +}
>
>   void qemu_get_timer(QEMUFile *f, QEMUTimer *ts);
>   void qemu_put_timer(QEMUFile *f, QEMUTimer *ts);


--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.