[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] [PATCHv7 01/22] aio / timers: Add qemu_clock_free
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [RFC] [PATCHv7 01/22] aio / timers: Add qemu_clock_free and expose qemu_clock_new and clock types |
|
Date: |
Wed, 7 Aug 2013 17:47:15 +0200 |
On Aug 07 2013, Alex Bligh wrote:
>
> --On 7 August 2013 13:31:07 +0200 Stefan Hajnoczi
> <address@hidden> wrote:
>
> > Regarding doc comments: if the function is self-documenting then the doc
> > comment might not add much. I think in those cases it's okay to omit
> > details about arguments or return values if they are clear from the
> > function prototype.
>
> Given I've done them for every function, I hope they don't cause any
> active harm. I was concerned that with an API change some things that
> one might have thought were obvious are in fact not obvious (e.g.
> timer_del vs. timer_free).
No, they definitely do not harm.
Paolo
- [Qemu-devel] [RFC] [PATCHv7 00/22] aio / timers: Add AioContext timers and use ppoll, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 02/22] aio / timers: add qemu-timer.c utility functions, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 03/22] aio / timers: Consistent treatment of disabled clocks for deadlines, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 04/22] aio / timers: add ppoll support with qemu_poll_ns, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 05/22] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 06/22] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 09/22] aio / timers: Add QEMUTimerListGroup and helper functions, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 10/22] aio / timers: Add QEMUTimerListGroup to AioContext, Alex Bligh, 2013/08/06