Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

[Kevin Wolf]

Am 08.08.2013 um 15:37 hat Benoît Canet geschrieben:
> > Kevin's series renamed these to have a dash in the name, and also moved
> > all the throttling parameters into a sub-struct.  Does it make more
> > sense to have just '*throttling' with that sub-struct containing 12
> > parameters, 6 for limits and 6 for thresholds, or would it be better to
> > have '*throttling' with 6 members for limits, as well as
> > '*throttling-threshold' with the other 6 members?  Naming-wise,
> > throttling.bps-total and throttling-threshold.bps-total convey as much
> > information as throttling.bps-total and throttling.bps-total-threshold.
> 
> Eric & Kevin:
> 
> Should compatible old style values be added for the new throttling options in
> order to avoid a mixed style mess in qemu-options.hx ?

No, I don't think new options should get an old-style alias. We should
simply convert the documentation in qemu-options.hx consistently to the
new style.

Kevin