qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] [PATCHv8 28/30] aio / timers: Add scripts/switch-


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC] [PATCHv8 28/30] aio / timers: Add scripts/switch-timer-api
Date: Fri, 09 Aug 2013 16:37:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

Il 09/08/2013 16:35, Alex Bligh ha scritto:
> 
> On 9 Aug 2013, at 11:26, Paolo Bonzini wrote:
> 
>> Il 08/08/2013 23:42, Alex Bligh ha scritto:
>>> +       # these have just changed name
>>> +       $line =~ s/\bqemu_mod_timer\b/qemu_timer_mod/g;
>>> +       $line =~ s/\bqemu_mod_timer_(ns|us|ms)\b/qemu_timer_mod_$1/g;
>>> +       $line =~ s/\bqemu_free_timer\b/qemu_timer_free/g;
>>> +       $line =~ s/\bqemu_del_timer\b/qemu_timer_del/g;
>>
>> I couldn't quite track which patch introduced this change.
>>
>> I would either go all the way and drop the qemu_ prefix, or leave the
>> old name in place.
> 
> As per previous comment, they can't stay the same because at various
> stages in the process both apis are used. If we don't want to keep
> qemu_timer_ for the static situation, I suggest we just go to timer_.

Sure.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]