[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] vmdk: support vmfsSparse files |
|
Date: |
Mon, 12 Aug 2013 13:28:14 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sun, Aug 11, 2013 at 06:13:57PM +0200, Paolo Bonzini wrote:
> @@ -505,6 +505,34 @@ static int vmdk_open_vmdk3(BlockDriverState *bs,
> return ret;
> }
>
> +static int vmdk_open_vmfs_sparse(BlockDriverState *bs,
> + BlockDriverState *file,
> + int flags)
> +{
> + int ret;
> + uint32_t magic;
> + VMDK3Header header;
> + VmdkExtent *extent;
> +
> + ret = bdrv_pread(file, sizeof(magic), &header, sizeof(header));
> + if (ret < 0) {
> + return ret;
> + }
magic is unused. Did you forget to check it?