qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type p


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v5] vl.c: Output error on invalid machine type provided
Date: Mon, 12 Aug 2013 10:16:46 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

On 08/12/2013 09:58 AM, Michal Novotny wrote:
> 
> On 08/12/2013 05:55 PM, Eric Blake wrote:
>> On 07/31/2013 01:04 AM, Michal Novotny wrote:
>>> Output error message using qemu's error_report() function when user
>>> provides the invalid machine type on the command line. This also saves
>>> time to find what issue is when you downgrade from one version of qemu
>>> to another that doesn't support required machine type yet (the version
>>> user downgraded to have to have this patch applied too, of course).
>>>
>>> Signed-off-by: Michal Novotny <address@hidden>
>>> ---
>>>  vl.c | 5 +++++
>>>  1 file changed, 5 insertions(+)
>> Are you trying to get this in 1.6?
>>
>> Reviewed-by: Eric Blake <address@hidden>
>>
> 
> It's ok for 1.6. It applies cleanly. So if it's fine with you please
> push it to the repository.

I'm not the maintainer, so I'm not the one that can push it.  At this
phase in the game, it helps if you resend a patch with 'for 1.6' inside
the [] as part of the subject line, as well as cc the maintainer listed
by ./scripts/get_maintainer.pl, to make sure the actual maintainer sees
it and can make a more-informed decision on whether it qualifies as a
bug fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]