Re: [Qemu-devel] [RFC] [PATCHv10 08/31] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

[Jan Kiszka]

On 2013-08-12 18:25, Alex Bligh wrote:
> 
> On 12 Aug 2013, at 17:14, Jan Kiszka wrote:
> 
>> The typedef part is a duplication of what we already have in
>> qemu/typedefs.h and breaks the build for me. Just declare the struct here.
> 
> You mean one can't do
> 
> typedef struct foo foo;
> ...
> typedef struct foo {
>   ...
> } foo;
> 
> ?

Yes, at least according to the standard. Older gcc seem to reject it,
newer may have relaxed this by default.

> 
> I don't even get a warning for that. Learn a new thing every
> day. OK will fix. I guess that means timer.h needs to explicitly
> include typedefs.h in case whatever is including timer.h does
> not first include typedefs.h.

It works without explicit including as most users pull in qemu-common.h
as well, but it's cleaner of course.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux