[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock |
|
Date: |
Tue, 13 Aug 2013 16:53:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-08-13 16:52, Paolo Bonzini wrote:
> Il 13/08/2013 11:09, Jan Kiszka ha scritto:
>>>>>>>>
>>>>>>
>>>>>> As the usage pattern is
>>>>>>
>>>>>> seqlock_read_begin()
>>>>>> do
>>>>>> ...
>>>>>> while (seqlock_read_check())
>>>>>>
>>>>>> I would suggest to call the latter seqlock_read_retry(), just like the
>>>>>> kernel does.
>>>>>>
>>>> I think it contains the meaning of check-success-or-retry. So may
>>>> check be nicer?
>> "Check" alone has no obvious semantic for me, therefore "retry".
>
> I agree. I was writing the patch without looking at any Linux code
> (just to be safe since it's GPLv2-only) and misremembered the name of
> the API.
Another reason to forget about v2+. ;)
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
[Qemu-devel] [PATCH v2 2/4] timer: protect timers_state's clock with seqlock, Liu Ping Fan, 2013/08/13
[Qemu-devel] [PATCH v2 3/4] qemu-thread: add QemuEvent, Liu Ping Fan, 2013/08/13
[Qemu-devel] [PATCH v2 4/4] timer: make qemu_clock_enable sync between disable and timer's cb, Liu Ping Fan, 2013/08/13