Re: [Qemu-devel] [PATCH 7/7] switch raw block driver from "raw.o" to "raw_bsd.o"

[Kevin Wolf]

Am 18.08.2013 um 16:29 hat Paolo Bonzini geschrieben:
> Il 16/08/2013 16:15, Laszlo Ersek ha scritto:
> > +static int raw_reopen_prepare(BDRVReopenState *reopen_state,
> > +                              BlockReopenQueue *queue, Error **errp)
> >  {
> > -    return bdrv_reopen_prepare(bs->file);
> > +    BDRVReopenState tmp = *reopen_state;
> > +
> > +    tmp.bs = tmp.bs->file;
> > +    return bdrv_reopen_prepare(&tmp, queue, errp);
> >  }
> 
> This should just return zero, my fault.

Which is because bdrv_reopen_queue() already queues bs->file for reopen.
The simple return 0; implementation is shared by all other format drivers
that support reopening images.

Kevin